Thank you Hans, I look forward at it, but in the meantime thank you for taking action.
Kind regards, Jacopo On Feb 4, 2010, at 9:38 AM, Hans Bakker wrote: > Jacopo, > > please check r906373 where implemented your suggestions. > > Regtards, > Hans > > On Thu, 2010-01-28 at 11:15 +0100, Jacopo Cappellato wrote: >> Hi Hans, >> >> rev. 904006 ("Ebay API inventory functions") is an interesting contribution, >> thanks for working at it. >> I have only partially reviewed it and I have some suggestions: >> >> On Jan 28, 2010, at 10:13 AM, hans...@apache.org wrote: >> >>> Modified: >>> ofbiz/trunk/specialpurpose/ebay/script/org/ofbiz/ebay/ebay/EbayServices.xml >> >> in my opinion most of the code in this file, that is greatly based on the >> services from InventoryReserveServices.xml, could be slimmed down a lot if >> you just reuse the existing code and make it more flexible. >> For example, you could reuse the existing reserveForInventoryItemInline if >> you add an if condition to skip the calls to reserveOrderItemInventory if >> the orderId is missing. >> Similar patterns could be used for other services. >> >> What d you think? >> >> Jacopo >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates >