[ 
https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843199#action_12843199
 ] 

Scott Gray commented on OFBIZ-3533:
-----------------------------------

Few comments:
- The entity packages should probably be org.ofbiz.product.promo instead of 
org.ofbiz.product.product
- I'm not sure about re-using the ProductContentType entity for representing 
productPromoContentTypeIds, does anyone have an opinion on this?
- What is the reason for calling updateContent within the ProductPromoContent 
CrUD services?  Maybe the answer is obvious but I'm not fresh enough on the 
content stuff to know.

Thanks
Scott

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3533
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3533
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Amit Sharma
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality  with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key: 
> ## productPromoId 
> ## contentId 
> ## productPromoContentTypeId
> ## fromDate 
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper  ProductPromoContentWrapper
> # Add content tab at catalog -> promo 
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to