[ 
https://issues.apache.org/jira/browse/OFBIZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blas Rodriguez Somoza updated OFBIZ-3609:
-----------------------------------------

    Description: 
XHTML validation errors

    * Unclosed INPUT or IMG
    * attributes without values (checked, selected, disabled, etc)
    * attribute values without "
    * Uppercase tags or attributes.
    * Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be 
        <table cellspacing="0" class="basic-table">
              </td>
            </tr>
        </table>
Which is obviously wrong. Added an <#if to guard against wrong table markup 
when keywordThesauruses is empty.

FindProductPromoCode.ftl
Wrong markup at Line 27. Duplicated </span>

EditProductConfigItemContent.ftl
Wrong markup at line 99. Input can't be directly inside table. In this file the 
input can be one line before table tag without functional changes
   <table cellspacing="0" class="basic-table">
                <input type="hidden" name="configItemId" 
value="${configItemId?if_exists}">

Updated patch attached (v2)

  was:
XHTML validation errors

    * Unclosed INPUT
    * attributes without values (checked, selected, disabled, etc)
    * attribute values without "
    * Uppercase tags or attributes.
    * Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be 
        <table cellspacing="0" class="basic-table">
              </td>
            </tr>
        </table>
Which is obviously wrong. Added an <#if to guard against wrong table markup 
when keywordThesauruses is empty.

Patch attached


> XHTML validation errors (product)
> ---------------------------------
>
>                 Key: OFBIZ-3609
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3609
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3609_product_xhtml.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT or IMG
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be 
>         <table cellspacing="0" class="basic-table">
>               </td>
>             </tr>
>         </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup 
> when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file 
> the input can be one line before table tag without functional changes
>    <table cellspacing="0" class="basic-table">
>                 <input type="hidden" name="configItemId" 
> value="${configItemId?if_exists}">
> Updated patch attached (v2)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to