[
https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------
Description:
The rendering of fieldgroups in ModelForm is wrong
As an example, the beginning of the generated html for AddWorkEffortCommEvent
in the page workeffort->communications is (the places where there are mistakes
are marked with -----> comments)
<!-- Begin Form Widget - Form Element
component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent
-->
<form method="post" action="/workeffort/control/createCommunicationEvent"
id="AddWorkEffortCommEvent" class="basic-form"
onsubmit="javascript:submitFormDisableSubmits(this)"
name="AddWorkEffortCommEvent">
<input type="hidden" name="workEffortId" value="9202"
id="AddWorkEffortCommEvent_workEffortId"/>
<input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
<input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
<input type="hidden" name="messageId"
id="AddWorkEffortCommEvent_messageId"/>
<div class="fieldgroup" id="_G2_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G2__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
</table>
</div>
</div>
<table width="100%">
<tr>
<td align="left">
<div class="tabletext">Enter existing Communication Event
Id below</div>
</td>
</tr>
</table>
<div class="fieldgroup" id="_G3_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G3__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
<tr>
<td class="label">Communication Event Id </td>
<td colspan="4">
<div class="field-lookup">
<ul>
<li><input type="text"
name="communicationEventId" size="25"
id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
<li>
<a
href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
<span
id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display:
none" class="indicator"><img src="" alt=""/></span>
</a>
</li>
</ul>
</div>
<script language="JavaScript"
type="text/javascript">
ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=communicationEventId');
</script>
</td>
----------------> Here must be a tr close
</table>
</div>
</div>
<table width="100%">
<tr>
<td align="left">
<div class="tabletext">OR add new Communication Event data
below to create new entity (leave Communication Event Id empty)</div>
</td>
</tr>
</table>
<div class="fieldgroup" id="_G4_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G4__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
</tr>
<tr>
<td class="label">Description </td>
<td colspan="4">
<textarea name="description" cols="60" rows="3"
id="AddWorkEffortCommEvent_description"></textarea>
</td>
----------------> Here must be a tr close
</table>
</div>
</div>
<div class="fieldgroup" id="_G1_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G1__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
<td class="label">Parent Comm Event Id </td>
<td>
<div class="field-lookup">
<ul>
<li><input type="text"
name="parentCommEventId" size="25"
id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
<li>
<a
href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
<span
id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none"
class="indicator"><img src="" alt=""/></span>
</a>
</li>
</ul>
</div>
<script language="JavaScript"
type="text/javascript">
ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=parentCommEventId');
</script>
</td>
The same happen in:
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store
Patch attached.
Don't use this patch, there are one page that still generates bad html. I'll
post a new one when I solve the remaining issue.
was:
The rendering of fieldgroups in ModelForm is wrong
As an example, the beginning of the generated html for AddWorkEffortCommEvent
in the page workeffort->communications is (the places where there are mistakes
are marked with -----> comments)
<!-- Begin Form Widget - Form Element
component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent
-->
<form method="post" action="/workeffort/control/createCommunicationEvent"
id="AddWorkEffortCommEvent" class="basic-form"
onsubmit="javascript:submitFormDisableSubmits(this)"
name="AddWorkEffortCommEvent">
<input type="hidden" name="workEffortId" value="9202"
id="AddWorkEffortCommEvent_workEffortId"/>
<input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
<input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
<input type="hidden" name="messageId"
id="AddWorkEffortCommEvent_messageId"/>
<div class="fieldgroup" id="_G2_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G2__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
</table>
</div>
</div>
<table width="100%">
<tr>
<td align="left">
<div class="tabletext">Enter existing Communication Event
Id below</div>
</td>
</tr>
</table>
<div class="fieldgroup" id="_G3_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G3__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
<tr>
<td class="label">Communication Event Id </td>
<td colspan="4">
<div class="field-lookup">
<ul>
<li><input type="text"
name="communicationEventId" size="25"
id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
<li>
<a
href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
<span
id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display:
none" class="indicator"><img src="" alt=""/></span>
</a>
</li>
</ul>
</div>
<script language="JavaScript"
type="text/javascript">
ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=communicationEventId');
</script>
</td>
----------------> Here must be a tr close
</table>
</div>
</div>
<table width="100%">
<tr>
<td align="left">
<div class="tabletext">OR add new Communication Event data
below to create new entity (leave Communication Event Id empty)</div>
</td>
</tr>
</table>
<div class="fieldgroup" id="_G4_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G4__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
</tr>
<tr>
<td class="label">Description </td>
<td colspan="4">
<textarea name="description" cols="60" rows="3"
id="AddWorkEffortCommEvent_description"></textarea>
</td>
----------------> Here must be a tr close
</table>
</div>
</div>
<div class="fieldgroup" id="_G1_">
<div class="fieldgroup-title-bar">
</div>
<div id="_G1__body" class="fieldgroup-body" >
<table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
<td class="label">Parent Comm Event Id </td>
<td>
<div class="field-lookup">
<ul>
<li><input type="text"
name="parentCommEventId" size="25"
id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
<li>
<a
href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
<span
id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none"
class="indicator"><img src="" alt=""/></span>
</a>
</li>
</ul>
</div>
<script language="JavaScript"
type="text/javascript">
ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=parentCommEventId');
</script>
</td>
The same happen in:
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store
Patch attached.
> XHTML validation errors (framework/widget) Buggy render of fieldgroups in
> ModelForm
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-3626
> URL: https://issues.apache.org/jira/browse/OFBIZ-3626
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3626_framework_widget_xhtml.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent
> in the page workeffort->communications is (the places where there are
> mistakes are marked with -----> comments)
> <!-- Begin Form Widget - Form Element
> component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent
> -->
> <form method="post" action="/workeffort/control/createCommunicationEvent"
> id="AddWorkEffortCommEvent" class="basic-form"
> onsubmit="javascript:submitFormDisableSubmits(this)"
> name="AddWorkEffortCommEvent">
> <input type="hidden" name="workEffortId" value="9202"
> id="AddWorkEffortCommEvent_workEffortId"/>
> <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
> <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
> <input type="hidden" name="messageId"
> id="AddWorkEffortCommEvent_messageId"/>
> <div class="fieldgroup" id="_G2_">
> <div class="fieldgroup-title-bar">
> </div>
> <div id="_G2__body" class="fieldgroup-body" >
> <table cellspacing="0" class="basic-table">
> </table>
> </div>
> </div>
> <table width="100%">
> <tr>
> <td align="left">
> <div class="tabletext">Enter existing Communication Event
> Id below</div>
> </td>
> </tr>
> </table>
> <div class="fieldgroup" id="_G3_">
> <div class="fieldgroup-title-bar">
> </div>
> <div id="_G3__body" class="fieldgroup-body" >
> <table cellspacing="0" class="basic-table">
> <tr>
> <td class="label">Communication Event Id </td>
> <td colspan="4">
> <div class="field-lookup">
> <ul>
> <li><input type="text"
> name="communicationEventId" size="25"
> id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
> <li>
> <a
> href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
> <span
> id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display:
> none" class="indicator"><img src="" alt=""/></span>
> </a>
> </li>
> </ul>
> </div>
> <script language="JavaScript"
> type="text/javascript">
>
> ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=communicationEventId');
> </script>
> </td>
> ----------------> Here must be a tr close
> </table>
> </div>
> </div>
> <table width="100%">
> <tr>
> <td align="left">
> <div class="tabletext">OR add new Communication Event
> data below to create new entity (leave Communication Event Id empty)</div>
> </td>
> </tr>
> </table>
> <div class="fieldgroup" id="_G4_">
> <div class="fieldgroup-title-bar">
> </div>
> <div id="_G4__body" class="fieldgroup-body" >
> <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
> </tr>
> <tr>
> <td class="label">Description </td>
> <td colspan="4">
> <textarea name="description" cols="60" rows="3"
> id="AddWorkEffortCommEvent_description"></textarea>
> </td>
> ----------------> Here must be a tr close
> </table>
> </div>
> </div>
> <div class="fieldgroup" id="_G1_">
> <div class="fieldgroup-title-bar">
> </div>
> <div id="_G1__body" class="fieldgroup-body" >
> <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
> <td class="label">Parent Comm Event Id </td>
> <td>
> <div class="field-lookup">
> <ul>
> <li><input type="text"
> name="parentCommEventId" size="25"
> id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
> <li>
> <a
> href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
> <span
> id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none"
> class="indicator"><img src="" alt=""/></span>
> </a>
> </li>
> </ul>
> </div>
> <script language="JavaScript"
> type="text/javascript">
>
> ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&searchValueField=parentCommEventId');
> </script>
> </td>
> The same happen in:
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.
> Don't use this patch, there are one page that still generates bad html. I'll
> post a new one when I solve the remaining issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
