[
https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853248#action_12853248
]
Jacques Le Roux commented on OFBIZ-3541:
----------------------------------------
Hi BIlgin,
IIRW (I did not check) it's only beause of the decorators names, could be more
reasons see OFBIZ-3442. Anyway this was mostly related to the testing phase. We
should be able to simplify this and other points as we already discussed by
setting the defaults in the renderer (I repeat: layer and topleft). For the
moment actually there are only 4 points remaining:
* cross button in header which does not close before you click inside the
layer, not a big deal for now as there is a workaroud, Sascha will quickly fix
this later he said
* the minize button (+ -) has a problem, [we have an idea on how to fix that
thanks to Ankit
Jain|https://issues.apache.org/jira/browse/OFBIZ-3446?focusedCommentId=12851807&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12851807]
* the lookups that call calendars should not be layered until we solve the
issue with them. I think Sascha will be able to solve that when he will come
back
* 2 inputs fields in FTL are shared (see my comment above) and we will need to
keep them as is as long as we don't find an answer for them. The only drawback
is the button image in Tomahawk.
So nothing is really blocking now and we should be ok to commit all soon.
Thanks for commiting you patch and updating mine :)
> Using Widgets html form templates in FTL files
> ----------------------------------------------
>
> Key: OFBIZ-3541
> URL: https://issues.apache.org/jira/browse/OFBIZ-3541
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Attachments: OFBIZ-3541 Using Widgets html form templates in FTL
> files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch,
> OFBIZ-3541 Using Widgets html form templates in FTL files.patch,
> widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch,
> widgetMacrosInFtlImprove.patch.diff
>
>
> The attached patch introduces a way to let developers to use the templates
> defined in htmlMacroFormLibrary.ftl in the FTL files.
> This was discussed in the mailing list and it seems that we all agree that
> having this feature could be a good thing.
> In the patch I used the renderLookupField in the main.ftl file of the catalog
> application. By doing this the two lookups that are included in this ftl are
> now rendered similar to how they are from a form widget.
> This allows the Tomahawk theme to render these lookups in the supposed way
> (with the card icon).
> Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all
> parameters with a default value so that only the relevant ones must be
> specified in the FTL.
> A new template.ftl file has been added but this only includes the
> htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the
> macro available in the FTL file.
> Please fill free to comment any of the choise I did so that we could then
> commit this and extend to other macros.
> I guess the next one I will address is the renderNextPrev so that all
> paginations will look the same in all forms/FTL screens.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
