[ https://issues.apache.org/jira/browse/OFBIZ-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3599. ---------------------------------- Assignee: Jacques Le Roux Resolution: Fixed Thanks Bob, I committed your patch in trunk at r932681 I have 2 remarks. I understand why you changed this line. But I did not check the logic, did you? Else I'd appreciate if someone acquainted with this code could have a look - String serialNumber = (String) serialNumberIter.next(); + String serialNumber = serialNumberList.get(0); Also I wondered why you casted logicalId (which is a String) to an Object in the line below. - omiPkMap = UtilMisc.toMap("logicalId", logicalId, "component", component, "task", task, "referenceId", referenceId); + omiPkMap = UtilMisc.toMap("logicalId", (Object) logicalId, "component", component, "task", task, "referenceId", referenceId); Also is it really needed to have omiPkMap defined as Map<String, Object>, would not Map<String, String> be better? I finally compiled with Map<String, String> and as it was ok committed with it. Please let me know if you see any issues with that > specialpurpose - oagis > ---------------------- > > Key: OFBIZ-3599 > URL: https://issues.apache.org/jira/browse/OFBIZ-3599 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bob Morley > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3599_ResolveJavaWarningsOagis.patch > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira