[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857234#action_12857234 ]
Jacques Le Roux edited comment on OFBIZ-3442 at 4/15/10 4:36 AM: ----------------------------------------------------------------- This is the last patch with the minium modifications needed to replace all popup lookups by layered lookup. I have already identified some cases where we want not to use layered lookups. LookupTimeDuration is one there are maybe others but I wonder at this stage if I will get enough support from this issue or I will not rather commit as is and wait returns to fix issues as it's realy easy to fix since a simple <<presentation="window">> attribute does the trick As I said there are still some issues though, notably with # the last lookup (at bottom) of https://localhost:8443/workeffort/control/EditWorkEffort?workEffortTypeId=TASK¤tStatusId=CAL_NEEDS_ACTION : look for ProductId inside. This is something specific to layer in layer and we have already OFBIZ-3446 opened for that # same with https://localhost:8443/content/control/FindSurvey (acroform) # also https://localhost:8443/assetmaint/control/LookupWorkEffort (recursive issue: look for parent) we have already OFBIZ-3693 opened for that # The minimize/enlarge buttons (+ -) blocks the layer see OFBIZ-3692 # I saw still some problems in themes other than Tomahawk According to Ankit Jain (see OFBIZ-3446), it seems that when you use the attribute <<presentation="layer">> attribute some of these issues does not exist. I have also noticed some differences but at this stage I'm not quite sure. I will revisit this ASAP but maybe not today. I'd really appreciate more testing, thanks for you help was (Author: jacques.le.roux): This is the last patch with the minium modifications needed to replace all popup lookups by layered lookup. I have already identified some cases where we want not to use layered lookups. LookupTimeDuration is one there are maybe others but I wonder at this stage if I will get enough support from this issue or I will not rather commit as is and wait returns to fix issues as it's realy easy to fix since a simple <<presentation="window">> attribute does the trick As I said there are still some issues though, notably with # the last lookup (at bottom) of ttps://localhost:8443/workeffort/control/EditWorkEffort?workEffortTypeId=TASK¤tStatusId=CAL_NEEDS_ACTION : look for ProductId inside. This is something specific to layer in layer and we have already OFBIZ-3446 opened for that # same with https://localhost:8443/content/control/FindSurvey (acroform) # also https://localhost:8443/assetmaint/control/LookupWorkEffort (recursive issue: look for parent) we have already OFBIZ-3693 opened for that # The minimize/enlarge buttons (+ -) blocks the layer see OFBIZ-3692 # I saw still some problems in themes other than Tomahawk According to Ankit Jain (see OFBIZ-3446), it seems that when you use the attribute <<presentation="layer">> attribute some of these issues does not exist. I have also noticed some differences but at this stage I'm not quite sure. I will revisit this ASAP but maybe not today. I'd really appreciate more testing, thanks for you help > Replace popup lookups by layer lookups > -------------------------------------- > > Key: OFBIZ-3442 > URL: https://issues.apache.org/jira/browse/OFBIZ-3442 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch > > > Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and > improvements OFBIZ-3430, I propose now to replace old the popup lookups by > layered (Ajaxified) lookups. > For that please find a patch attached. In this patch I followed a simple S/R > tactic: > * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator > in screens > * I replaced all occurences of <lookup by <lookup presentation="layer" > position="center" > It's as simple as this. For the moment I decided to use as default > position="center" because it's was the easiest (sure that any lookups will be > out of the screen). I think we will refine this by removing position="center" > and use the default (position="normal") which does not move the layer from > the point it's called and will be more aesthetic. > I did not test anything in OFBIz OOTB for the moment, but I already use > layered lookups in a custom application without any issues so far. > The only drawback I found for the moment is when a lookup is called from a > lookup. If you are aware of such cases please chime in. > Of course everybody is encouraged to test this improvement as much as > possible. I really think it's a very cool feature for users, and they will > appreciate. There are still some ideas like that (see the link Sasca referred > to in OFBIZ-3374), and we will try to implement them. > There are issues to be fixed prior to a commit, see OFBIZ-3446. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira