[
https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857688#action_12857688
]
Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------
Hi Jacques,
sry for mmy late response. Good idea with the min. modifications. I tested your
patch and i see one issue. You changed the call method but not the lookups
itself. Remember we set an extra decorator for the new lookups because of the
different behavior (LookupLayerPopupDecorator). That causes some issus when i
try to open a layer form a layer (tested in Workeffort). I think the easiest
way to fix this is to make the new decorator default (rename in
"LookupLayerDecorator" and the old LookupLayerDecorator in
"LookupLayerWindowDecorator") then you have to do only a few changes in the
decorators you want to open in the classic way.
What do you think about it??
Have a nice day
Sascha
> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and
> improvements OFBIZ-3430, I propose now to replace old the popup lookups by
> layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R
> tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator
> in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer"
> position="center"
> It's as simple as this. For the moment I decided to use as default
> position="center" because it's was the easiest (sure that any lookups will be
> out of the screen). I think we will refine this by removing position="center"
> and use the default (position="normal") which does not move the layer from
> the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use
> layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a
> lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as
> possible. I really think it's a very cool feature for users, and they will
> appreciate. There are still some ideas like that (see the link Sasca referred
> to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
