[
https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858257#action_12858257
]
Blas Rodriguez Somoza edited comment on OFBIZ-3708 at 4/17/10 10:31 PM:
------------------------------------------------------------------------
Hi Adam
I partially agree about the 2 first items, I suppose it could be resolved, but
I don't how difficult it could be and how each browser will behave.
The solution could be easy or a nightmare, but surely it will make css styles
more complex and not easier.
Anyway, If we agree that those fields must be valid to be included inside a
inline element, then the patch attached is the minimal one.
In html FormMacroLibrary (macros renderDateTimeField, renderRadioField,
renderDateFindField and renderLookupField)
- DIV changed to SPAN
- Removed UL and LI because UL is a block element and LI must be inside a list.
(As Adrian say in his comment)
In themes CSS files
- Styles corrected to match the changes. (display changed from block to
inline-block and alignment changed to maintain the vertical position)
Is this OK for you ?
was (Author: brsomoza):
Hi Adam
I partially agree about the 2 first items, I suppose it could be resolved, but
I don't how difficult it could be and how each browser will behave.
The solution could be easy or a nightmare, but surely it will make css styles
more complex and not easier.
Anyway, If we agree that those fields must be valid to be included inside a
inline element, then patch attached is the minimal one.
In html FormMacroLibrary (macros renderDateTimeField, renderRadioField,
renderDateFindField and renderLookupField)
- DIV changed to SPAN
- Removed UL and LI because UL is a block element and LI must be inside a list.
(As Adrian says in his comment)
In themes CSS files
- Styles corrected to match the changes. (display changed from block to
inline-block and alignment changed to maintain the vertical position)
Is this OK for you ?
> Fields should be defined with span not div. (radio, date, lookup)
> -----------------------------------------------------------------
>
> Key: OFBIZ-3708
> URL: https://issues.apache.org/jira/browse/OFBIZ-3708
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg,
> CAL_bluelight_after.jpg, CAL_bluelight_before.jpg,
> CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg,
> CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg,
> CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg,
> LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg,
> LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg,
> LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg,
> LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg,
> LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff
>
>
> Field markup should be a valid inline element.
> Defining fields with div (block) instead of span (inline) creates several
> problems:
> - Missalignments in screen. (See LOOKUP_CAL screenshots)
> - Implies a end-of-line after the div. (See CAL screenshots)
> - If used inside inline elements which should be OK, becames XHTML validation
> errors. (Manufacturing -> MRP -> MRP log)
> Because this is a markup problem, it spans to all the themes.
> This patch contains 2 files in the framework/widget area and 5 in the themes
> area.
> Because the source of the problem is in the framework/widget area, I opt to
> assign the bug to the framework area.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
