That would be the best fast approach, but does result in invalid xhtml because src (and alt?) are required attributes of an img element. But a little invalid xhtml is better than double requests.
Regards Scott On 2/05/2010, at 8:45 PM, Hans Bakker wrote: > thank you for your quick reply... to solve the problem revert this? > > On Sun, 2010-05-02 at 20:19 +1200, Scott Gray wrote: >> From a quick look at the diff, my guess is this change caused the problem: >> >> Modified: ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=929173&r1=929172&r2=929173&view=diff >> ============================================================================== >> --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl >> (original) >> +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl Tue Mar >> 30 15:35:28 2010 >> @@ -449,7 +449,7 @@ ${item.description}</div> >> </#list> >> </#if> >> );"> >> -<#if ajaxEnabled?has_content && ajaxEnabled><span id="${id}_indicator" >> style="display: none" class="indicator"><img /></span></#if> >> +<#if ajaxEnabled?has_content && ajaxEnabled><span id="${id}_indicator" >> style="display: none" class="indicator"><img src="" alt=""/></span></#if> >> </a></li><#rt> >> <#if disabled?has_content && disabled><li><a id="${id}_clear" >> style="background:none;margin-left:-6px;margin-right:15px;" >> class="clearField" href="javascript:void();" >> onclick="javascript:document.${formName}.${name}.value='';<#if >> descriptionFieldName?has_content>document.${formName}.${descriptionFieldName}.value='';</#if>">${clearText}</a></li></#if> >> </ul></div> >> >> Having an image with an empty src attribute is equivalent to setting the src >> to the current page url, so the browser goes to it to retrieve the image >> resulting in a second request. >> >> Regards >> Scott >> >> On 2/05/2010, at 7:41 PM, Hans Bakker wrote: >> >>> It also does not work in firefox. >>> >>> Adrian can you please have a look at this? can you either revert it or >>> fix it? I would appreciate it. >>> >>> Regards, >>> Hans >>> >>> On Tue, 2010-04-27 at 11:16 +0700, Hans Bakker wrote: >>>> I am using chrome here..... >>>> >>>> On Tue, 2010-04-27 at 15:43 +1200, Scott Gray wrote: >>>>> I've noticed this from time to time as well. For some reason only in >>>>> Safari but not in Firefox. >>>>> >>>>> Regards >>>>> Scott >>>>> >>>>> HotWax Media >>>>> http://www.hotwaxmedia.com >>>>> >>>>> On 27/04/2010, at 2:48 PM, Hans Bakker wrote: >>>>> >>>>>> i found an easier request to do the test to avoid the portal processing: >>>>>> https://localhost3:8443/partymgr/control/NewDraftCommunicationEvent >>>>>> >>>>>> or on the demo server: >>>>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewDraftCommunicationEvent >>>>>> >>>>>> the url below should read: >>>>>> https://demo-trunk.ofbiz.apache.org/myportal/control/showPortalPage?communicationEventTypeId=EMAIL_COMMUNICATION&partyIdFrom=admin&my=My&statusId=COM_PENDING&form=new&portalPageId=MYPORTAL_EMPLOYEE0 >>>>>> >>>>>> regards, >>>>>> Hans >>>>>> >>>>>> On Tue, 2010-04-27 at 09:42 +0700, Hans Bakker wrote: >>>>>>> Hi Adrian, >>>>>>> >>>>>>> could you please have a look at the above revision? >>>>>>> >>>>>>> starting with this revision some requests are executed twice. >>>>>>> >>>>>>> please try >>>>>>> https://demo-trunk.ofbiz.apache.org/partymyportal/control/showPortalPage?communicationEventTypeId=EMAIL_COMMUNICATION&partyIdFrom=admin&my=My&statusId=COM_PENDING&form=new&portalPageId=MYPORTAL_EMPLOYEE0 >>>>>>> >>>>>>> with this request a new email gets created twice, have a look at the >>>>>>> communicationeventid it gets with every execution of 2 more and 2 >>>>>>> communicatioon events were getting created. >>>>>>> >>>>>>> if you look in the log you will see that this request is executed twice. >>>>>>> >>>>>>> reverting back to revision 929171 it works: only one communication event >>>>>>> is created. >>>>>>> >>>>>>> Regards, >>>>>>> Hans >>>>>>> >>>>>> -- >>>>>> Ofbiz on twitter: http://twitter.com/apache_ofbiz >>>>>> Myself on twitter: http://twitter.com/hansbak >>>>>> Antwebsystems.com: Quality services for competitive rates. >>>>>> >>>>> >>> -- >>> Ofbiz on twitter: http://twitter.com/apache_ofbiz >>> Myself on twitter: http://twitter.com/hansbak >>> Antwebsystems.com: Quality services for competitive rates. >>> >> > -- > Ofbiz on twitter: http://twitter.com/apache_ofbiz > Myself on twitter: http://twitter.com/hansbak > Antwebsystems.com: Quality services for competitive rates. >
smime.p7s
Description: S/MIME cryptographic signature
