[ https://issues.apache.org/jira/browse/OFBIZ-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864845#action_12864845 ]
Bob Morley commented on OFBIZ-3749: ----------------------------------- Two quick questions ... 1) Since Debug.logInfo ultimately determines if logging for "info" is on, isn't it better to just call Debug.logInfo directly (paying the string construction penalty of course) ? 2) While it is pretty unlikely that the help key here would be defined in the resource bundle with the same value; this code would turn those into empty string. Would it be better to overload getMessage to allow an optional default message ... so we could do ... String fieldDescription = UtilProperties.getMessage(entityResourceName, messageId, locale, null); if (fieldDescription == null) { ... > Field description tooltips show key if help text is not found > ------------------------------------------------------------- > > Key: OFBIZ-3749 > URL: https://issues.apache.org/jira/browse/OFBIZ-3749 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: chris snow > Assignee: Erwan de FERRIERES > Fix For: Release Branch 10.04, SVN trunk > > Attachments: UtilHelpText.patch > > > Tooltip currently shows field help message key if no help text has been > provided. For details, see: > http://ofbiz.135035.n4.nabble.com/New-branch-is-now-available-for-upcoming-releases-of-10-04-series-tp2111929p2122465.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.