I forgot to commit the change in ShipmentCostEstimate: add productStoreShipMethId to ShipmentCostEstimate when created by
createShipmentEstimate
It's done at r985902 and will be backported in R10.04 and R9.04
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
"Cost calculation is still broken and no shipping costs are returned." is fixed
at revision: 985856 in trunk, r985860 in R10.04
I have also backported r931594+931595 in R9.04 at r985858+985862 and merged
985856 at r985872
And yes, I ran tests (hope you appreciate the effort ;o). But woooo... it's a long process with Derby with ant clean-all and
run-install before... I did not look into details though, I ran them, had a quick look at the log, that's all.
Note that nothing still is calculated for Fedex. I'm not quite sure if it's related, but Fedex has changed/is changing how things
work. The API is deprecated, replaced by web services and will be totally unusable in June 2012
http://fedex.com/us/developer/product/migration.html. I should work on this for a client and will contribute as much as
possible...
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
I think there are 2 solutions for this.
We could add productStoreShipMethId values to ShipmentCostEstimate demo data. This implies to also set productStoreShipMethId
values
to ProductStoreShipmentMeth
Now think about it, there are no productStoreShipMethId values in demo data. While installing demo data, they are created on the
fly
in the order of appearance for ProductStoreShipmentMeth because it's primary
key, but not in ShipmentCostEstimate.
So they are missing and it's the problem at hand. Note that
productStoreShipMethId is not added to ShipmentCostEstimate by
createShipmentEstimate. It's used to get information from
ProductStoreShipmentMeth but not put in ShipmentCostEstimate yet.
1) A very simple solution could be to remove productStoreShipMethId from
ShipmentCostEstimate.
2) But for me, the best solution is to add productStoreShipMethId values for both ProductStoreShipmentMeth and
ShipmentCostEstimate
demo data and to add productStoreShipMethId to ShipmentCostEstimate when
created by createShipmentEstimate
If nobody see a problem with that I will do 2)
Thanks
Jacques
From: "rohit" <rohitksur...@yahoo.com>
Hi cost calculation is still broken and no shipping costs are returned.
Another interesting thing that i noticed was that although shipping costs
for all options are showing as '0' and the log also says that no shipping
estimates are returned, if select any of the shipping options and move to
the next step in the checkout process, the shopping cart total shows the
correctly calculated shipping total. Also the order confirmation page shows
the selected shipping options and the calculated shipping estimate.
Thus, i guess the code has got broken only in the checkoutopions page, where
the shipping estimated are showing as '0'.
thanks,
rohit
2010-06-27 13:49:03,129 (TP-Processor8) [ ShipmentServices.java:266:WARN ]
No shipping estimates found; the shipping amount returned is 0!
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Re-svn-commit-r931594-ofbiz-trunk-applications-product-src-org-ofbiz-shipment-shipment-ShipmentServia-tp2013854p2270198.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
