[ 
https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910916#action_12910916
 ] 

Nicolas Malin commented on OFBIZ-3625:
--------------------------------------

Hi review the patch, I like it Bruno :) . Use generic  <include-portal-page> as 
<include-screen> it's a good idea. 

Just remark on code organization, why don't create a directory portal in 
framework/widget/src/org/ofbiz/widget to put all Portal*.java file ? As menu, 
from, and tree.

I have in my todo list to continue your work and add others generic call on 
form widget to call or refresh portlet  but it's an other issue

Tks for your works Bruno
Nicolas

> Adding a portal-page widget
> ---------------------------
>
>                 Key: OFBIZ-3625
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3625
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: ofbiz.log, portalPageWidget.patch, 
> portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch
>
>
> Hi,
> sometime ago we discussed about the opportunity to have the portalPage 
> implemented as a widget.
> This would allow a greater integration of the portal/portlet system in every 
> OFBiz screen.
> I have done some work on it following how other widgets have been implemented.
> I am not a java expert and I have difficulties to step further.
> I would like you java gurus to give a look to it and please help in 
> finalizing it.
> With the actual patch a  <portal-page id="EXAMPLE" /> is added at the bottom 
> of the https://localhost:8443/example/control/FindExample page.
> This is only a test page.
> From the error I get it seems that it is not possible to render the following 
> ftl in the htmlScreenMacroLibrary.ftl
> -----------------------------------------------------------------------------------------------------------------
>   <#if screenName?has_content>
>     <#assign portletFields = '<input name="portalPageId" value="' + 
> portalPageId + '" type="hidden"/><input name="portalPortletId" value="' + 
> portalPortletId + '" type="hidden"/><input name="portletSeqId" value="' + 
> portletSeqId  + '" type="hidden"/>'>
>     <form method="post" action="movePortletToPortalPage" 
> name="movePP_${portletIndex}">${portletFields}<input name="newPortalPageId" 
> value="${portalPageId}" type="hidden"/></form>
>     <div id="${portletIndex}" name="portalPortlet" class="noClass">
>       ${setRequestAttribute("portalPageId", portalPageId)}
>       ${setRequestAttribute("portalPortletId", portalPortletId)}
>       ${setRequestAttribute("portletSeqId", portletSeqId)}
>       ${screens.render(screenLocation, screenName)}
>       ${screens.setRenderFormUniqueSeq(portletIndex)}
>     </div>
>     <#-- DragNDrop is only activated, when the portal Page isn't the Default 
> page -->
>     <#if 
> originalPortalPageId?has_content><script>setMousePointer("${portletIndex}")</script></#if>
>     <#if originalPortalPageId?has_content><script 
> type="text/javascript">makeDragable("${portletIndex}");</script></#if>
>     <#if originalPortalPageId?has_content><script 
> type="text/javascript">makeDroppable("${portletIndex}");</script></#if>
>     <form method="post" 
> action="<@ofbizUrl>updatePortalPagePortletAjax</@ofbizUrl>" 
> name="freeMove_${portletIndex}">${portletFields}<input name="columnSeqId" 
> value="${columnSeqId}" type="hidden"/><input name="mode" value="RIGHT" 
> type="hidden"/></form>
>   </#if>
> -----------------------------------------------------------------------------------------------------------------
> Thank you for any collaboration to step this to the trunk.
> -Bruno

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to