[ 
https://issues.apache.org/jira/browse/OFBIZ-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915539#action_12915539
 ] 

Adrian Crum commented on OFBIZ-3959:
------------------------------------

I don't have an example. Just imagine a model class whose only methods are a 
constructor, an accept method, and accessor methods.

That shouldn't affect the builder pattern, so I wouldn't worry too much about 
it.



> Introduce a ModelEntityReaderBuilder to decouple ModelEntity and ModelReader
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-3959
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3959
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: chris snow
>            Priority: Minor
>
> ModelEntity is quite tightly coupled to ModelReader.  I'm assuming 
> ModelEntity is primarily responsible for representing a model of an entity, 
> however, it is also mixed with logic for building itself from the xml 
> definition.  For me it seems like the build logic should be moved to another 
> class, e.g. ModelEntityReaderBuilder that is responsible for building the 
> ModelEntity from the ModelReader?
> See: 
> http://ofbiz.135035.n4.nabble.com/entity-engine-separation-of-concerns-td2715929.html#a2715929

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to