[ 
https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917542#action_12917542
 ] 

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Hi Ankit,

There  is an issue in your patch. In Jquery  
{code}
if (jQuery(selector)) {
{code}
does not work you have to check if it exists. The easier is to use 
{code}
if (jQuery(selector).lenght) {
{code}

We would create an exist() function. Its code would be

{code}
jQuery.fn.exists = function(){return jQuery(this).length}
{code}
and would be used like that
{code}
if (jQuery(selector).exists()) {
   ...
}
{code}

But I'm not sure it's worth it (lenght is not intuitive but smaller than 
exists()). To be discussed...

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch
>
>
> All ecommerce js migration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to