[ 
https://issues.apache.org/jira/browse/OFBIZ-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921989#action_12921989
 ] 

Sascha Rodekamp commented on OFBIZ-3969:
----------------------------------------

Ok, i tested and it seems, that all needed labels will be loaded in the screens 
before triggering the mail service. So it's ready for commit.

> sendMailFrom Screen don't need to load uiLabels
> -----------------------------------------------
>
>                 Key: OFBIZ-3969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3969
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3969_OrderServices.patch
>
>
> Hi, 
> i noticed an issues in the sendOrderNotificationScreen method. There is no 
> need of loading uiLabels in the method, because the labels will be loaded in 
> the screen (which will be used for the email). 
> The point is, when someone (for whatever reason) don't add English uiLabels 
> and the service try to access the default English labels the an exception 
> will be thrown :-). This can be simply avoided.
> Cheers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to