[ 
https://issues.apache.org/jira/browse/OFBIZ-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3989.
----------------------------------

    Resolution: Fixed

Thanks Sascha,

I have commited the images at r1023664. 

About the patch, it works well for the lookup in lookup case (though I did not 
test the pure recursive case, but I guess it's ok) and the lookup chaining code 
looks better indeed.

For the TimeDuration lookup, I wonder why you hardcoded inside fieldlookup.js 
instead of setting the presentation parameter as you did for ListVisualThemes 
and ListTimezones. That's what  I did and it works well. Also we were missing 
fieldlookup.js in LookupDecorator therefore set_value was not working. Despites 
these changes the value was still not returned to the field. After some tries 
with write_value, and not enough time for it, I finally decided to create a 
specific set_duration_value function in fieldlookup.js in order to have it 
working without messing with set_value and write_value. It's good enough for 
me, tough I have the feeling that we should replace the timeDuration.ftl 
template by a widget form...

I have commited your modified patch at r1023701  



> Lookup bug fixes
> ----------------
>
>                 Key: OFBIZ-3989
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3989
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3933_lookupFix.patch
>
>
> Hi Jacques,
> a little lookup fix, which fixes:
> * the decorator issue for the milli sec lookup 
> [https://issues.apache.org/jira/browse/OFBIZ-3814]
> * a lookup in lookup issue regards to the identification of the calle lookup 
> (looukp chaining)
> BTW:
> can you please revert the folder
> themes/tomahawk/webapp/tomahawk/images
> Since our theme cleanup the ui images for the tomahawk theme are missing. 
> sorry i think i forgot to say delete all images except the once from the 
> tomahawk theme :-)
> Have a good evening
> Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to