[ 
https://issues.apache.org/jira/browse/OFBIZ-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934439#action_12934439
 ] 

Jacques Le Roux commented on OFBIZ-3987:
----------------------------------------

Hi Sascha,

I just a quick look at the code. Currently the line

ClassLoader loader = Thread.currentThread().getContextClassLoader();

is always called. With your change it's only when Distributed Cache Clear is 
used. Is that intended, could not be side effects?

Also there is a double check  for getDelegatorInfo().useDistributedCacheClear 
in initDistributedCacheClear (personnally I always prefer to have "if blocks" 
than "returns" before, except if there are very good reason).

Also I wonder why you are the only one to get this infinite loop, was it a 
specific case?

> infinite loop when instantiate the delegator using distributetCacheClear 
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-3987
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3987
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3987_DelegatorFactory.java.patch
>
>
> Hi Guys,
> we found an infinite loop when instantiate the delegator. This happens when 
> you use the distributetCacheClear .
> I moved the init of the dist cache clear to a separate method and call it in 
> the factory which resolves the loop issue.
> Have a good day
> Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to