[
https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983075#action_12983075
]
Jacques Le Roux commented on OFBIZ-4118:
----------------------------------------
Hi Arun,
I have commited the ebay component patch in trunk at r1060236
About the abasy store component I have a question about a trivial detail, I see
it's not a problem to apply
{code}
- if (categories.size() > 0) {
- toJsonObjectList(categories,response);
- }
+ toJsonObjectList(categories,response);
{code}
But I'd prefer to keep it, since it avoids an useless call
Also are you sure it's safe to apply this snippet?
{code}
- if (list != null) {
- for (Map<String,Object> val : list) {
- json = new JSONObject();
- for (String rowKey: val.keySet()) {
- json.put(rowKey, val.get(rowKey));
- }
- jsonList.add(json);
+ String jsonStr = null;
+ for (Map<String,Object> val : list) {
{code}
What if list is null, the enhanced foor loop does not guarantee no NPE in this
case
Else your patch sounds good to me, but I'm not quite sure how to test it as I
have never used this component. Could you give some hints please?
Thanks
> Some misc issues in ebay and ebayStore component.
> -------------------------------------------------
>
> Key: OFBIZ-4118
> URL: https://issues.apache.org/jira/browse/OFBIZ-4118
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ebay, specialpurpose/ebaystore
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Fix For: SVN trunk
>
> Attachments: ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch
>
>
> Following issues are exists in ebay and ebayStore component
> 1. Not getting ebay sub category from parent category on Export Product
> Listing screen of ebayStore component.
> 2. Error in getting category lookup form on Export Product Listing screen of
> ebayStore component..
> 3. JS is blocking during Export Product to ebay from ebay component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
