Or we could use a different h element.
My view on screenlets hasn't changed since our previous discussion: They
are used too much. Screens that are filled with dark title bars look bad.
-Adrian
On 1/19/2011 2:10 PM, Bruno Busco wrote:
Oh I see, you are right.
The search result screenlet title bar is not visible because it is not
collapsible.
Leaving it as it is now there is no room wasting.
We have only a difference in the "Search Options" and "Search Results"
strings styles.
This would be removed if we move the "Search Results" label in the screenlet
title like you did for the search options.
-Bruno
2011/1/19 Adrian Crum<[email protected]>
There is no title bar in search results, so there is nothing to change.
-Adrian
On 1/19/2011 12:48 PM, Bruno Busco wrote:
At the end you got it! ;-)
Could we do the same for the search results screenlet so that we close
these
issues ?
https://issues.apache.org/jira/browse/OFBIZ-3142
https://issues.apache.org/jira/browse/OFBIZ-1879
Thank you
-Bruno
2011/1/19<[email protected]>
Author: adrianc
Date: Wed Jan 19 07:39:16 2011
New Revision: 1060701
URL: http://svn.apache.org/viewvc?rev=1060701&view=rev
Log:
Move "Search Options" text to screenlet title bar in the FindDecorator
screen. It's now visible when the screenlet is collapsed.
Modified:
ofbiz/trunk/framework/common/widget/CommonScreens.xml
Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=1060701&r1=1060700&r2=1060701&view=diff
==============================================================================
--- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
+++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Wed Jan 19
07:39:16 2011
@@ -483,10 +483,9 @@ under the License.
</section>
<decorator-section-include name="menu-bar"/>
<container style="clear"/>
-<screenlet id="searchOptions" name="findScreenlet"
collapsible="true">
-<label style="h2"
text="${uiLabelMap.CommonSearchOptions}"/>
+<screenlet id="searchOptions" name="findScreenlet"
collapsible="true" title="${uiLabelMap.CommonSearchOptions}">
<container id="search-options">
-<decorator-section-include name="search-options"/>
+<decorator-section-include name="search-options"
/>
</container>
</screenlet>
<screenlet padded="false">
