Thanks Chirag! Improvements committed to trunk in r1061239
Regards Vikas On Thu, Jan 20, 2011 at 4:09 PM, Chirag Manocha <cmano...@emforium.com>wrote: > Hi Vikas, > I am bit confused with the method addProductPromoCode in ShoppingCart > class. > In ShoppingCartEvent you are calling this method on cart object and passing > the cart object as parameter too. > There is no need of passing the cart object, you can use keyword this > instead. > > Regards > -- > Chirag Manocha > Emforium Software Pvt. Ltd. | ALL-IN Software > +91-98735-47457 | +91-98263-19099 > Please don't print this Email unless you really need to - this will > preserve trees on planet earth. > > > > > From: m...@apache.org > To: comm...@ofbiz.apache.org > Sent: Thursday, January 20, 2011 3:54:21 PM > Subject: svn commit: r1061192 - in > /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: > ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java > > Author: mor > Date: Thu Jan 20 10:24:20 2011 > New Revision: 1061192 > > URL: http://svn.apache.org/viewvc?rev=1061192&view=rev > Log: > Bug fix: In a multiple store app now onwards a coupon code belonging to a > particular store will not be accepted if used on a different store. If user > attempts to do it, the > system will notify user that it is an invalid coupon code. Earlier the > coupon code was accepted but wasn't applied. Also it was preventing the user > to add > a correct coupon code. > >
