[ 
https://issues.apache.org/jira/browse/OFBIZ-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986372#action_12986372
 ] 

Jacques Le Roux commented on OFBIZ-4114:
----------------------------------------

I did not even try to build (I think it would have compile), it was obvious to 
me. Good catch BTW! 

> ServiceUtil.returnError called but its result not returned
> ----------------------------------------------------------
>
>                 Key: OFBIZ-4114
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4114
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: rev 1058379
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: 
> OFBIZ-4114_InvoiceServices_returnError_result_not_returned.patch, 
> OFBIZ-4114_PosTransaction_returnError_result_not_returned.patch
>
>
> In 
> applications/accounting/src/org/ofbiz/accounting/Invoice/InvoiceServices.java,
>  there are numerous calls to ServiceUtil.returnError where nothing is done 
> with the result of the call. Surely a
> return ServiceUtil.returnError
> was intended?
> A grep turned up one other place with a similar problem, PosTransaction.java .
> Patches attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to