What I have to do it in this case leave the compilation warning or remove it putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could work on the //FIXME later. What did you think of it ? Thanks Marco >----Messaggio originale---- >Da: jacques.le.r...@les7arts.com >Data: 08/02/2011 8.29 >A: <dev@ofbiz.apache.org> >Ogg: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java > >Maybe there is a reason? Because I saw Marco fixing a lot of them... > >Jacques > >From: "Adrian Crum" <adrian.c...@sandglass-software.com> >> It would be nice if we fixed the warnings instead of just hiding them. >> >> -Adrian >> >> On 2/7/2011 12:46 PM, mrisal...@apache.org wrote: >>> Author: mrisaliti >>> Date: Mon Feb 7 20:46:53 2011 >>> New Revision: 1068120 >>> >>> URL: http://svn.apache.org/viewvc?rev=1068120&view=rev >>> Log: >>> Remove compilation warnings of an unused private method in JNDIConfigUtil (OFBIZ-4102) >>> >>> Modified: >>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java >>> >>> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java >>> URL: >>> http://svn.apache. org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java?rev=1068120&r1=1068119&r2=1068120&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java (original) >>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil. java Mon Feb 7 20:46:53 2011 >>> @@ -43,6 +43,7 @@ public class JNDIConfigUtil { >>> } >>> } >>> >>> + @SuppressWarnings("unused") >>> private static Document getXmlDocument() throws GenericConfigException { >>> try { >>> return ResourceLoader.getXmlDocument(JNDIConfigUtil. JNDI_CONFIG_XML_FILENAME); >>> >>> >> > > >
