Hi Jacques,
I have removed the last FIXME introduced by me on the last commits and now
those variables/method that was never used it's now removed.
What about the serial warnings, may I could add a @SuppressWarnings("serial") ?
Thanks
Marco
Il giorno 08/feb/2011, alle ore 20.55, Jacques Le Roux ha scritto:
> I agree it's easier for me (in Eclipse) to find red lines (dots actually) in
> a page (class) than looking in the crowded FIXMEs list
>
> Thanks Marco for all the hard work BTW!
>
> Jacques
>
> adrian.c...@sandglass-software.com wrote:
>> I understand you are working on a big task, and I truly appreciate all
>> of your work. I agree that someone else could follow along later and
>> fix some of these errors. But it would be easier for that person to
>> find the errors if they were not hidden by @suppress annotations.
>> -Adrian
>> Quoting "mrisal...@libero.it" <mrisal...@libero.it>:
>>> Agreed, so in this case we could remove the private method that is not been
>>> used.
>>> Please keep in mind that is a very huge job to me and it's still not
>>> completed
>>> and everything can be corrected/improved !!!
>>> Thanks for the suggestions
>>> Marco
>>>> ----Messaggio originale----
>>>> Da: adrian.c...@sandglass-software.com
>>>> Data: 08/02/2011 14.59
>>>> A: <dev@ofbiz.apache.org>
>>>> Ogg: Re: R: Re: svn commit: r1068120 -
>>> /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>>>> You fix an unused method/variable by removing it. But leave the warning
>>>> in the unit tests - sometimes those are unavoidable.
>>>> -Adrian
>>>> On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
>>>>> What I have to do it in this case leave the compilation warning or remove
>>>>> it
>>>>> putting a //FIXME ?
>>>>> I would like to before to remove all the compilation warning and then we
>>>>> could
>>>>> work on the //FIXME later.
>>>>> What did you think of it ?
>>>>> Thanks
>>>>> Marco
>>>>>> ----Messaggio originale----
>>>>>> Da: jacques.le.r...@les7arts.com
>>>>>> Data: 08/02/2011 8.29
>>>>>> A:<dev@ofbiz.apache.org>
>>>>>> Ogg: Re: svn commit: r1068120 -
>>>>> /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>>>>>> Maybe there is a reason? Because I saw Marco fixing a lot of them...
>>>>>> Jacques
>>>>>> From: "Adrian Crum"<adrian.c...@sandglass-software.com>
>>>>>>> It would be nice if we fixed the warnings instead of just hiding them.
>>>>>>> -Adrian
>>>>>>> On 2/7/2011 12:46 PM, mrisal...@apache.org wrote:
>>>>>>>> Author: mrisaliti
>>>>>>>> Date: Mon Feb 7 20:46:53 2011
>>>>>>>> New Revision: 1068120
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=1068120&view=rev
>>>>>>>> Log:
>>>>>>>> Remove compilation warnings of an unused private method in
>>>>>>>> JNDIConfigUtil (OFBIZ-4102)
>>>>>>>> Modified:
>>>>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>>>>>>>> java
>>>>>>>> Modified:
>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>>>>>>>> URL:
>>>>>>>> http://svn.apache.
>>> org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>>>>> java?rev=1068120&r1=1068119&r2=1068120&view=diff
>>> ==============================================================================
>>>>>>>> ---
>>>>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>>>>>>>> java (original)
>>>>>>>> +++
>>>>>>>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>>>>>>>> java Mon Feb 7 20:46:53 2011
>>>>>>>> @@ -43,6 +43,7 @@ public class JNDIConfigUtil {
>>>>>>>> }
>>>>>>>> }
>>>>>>>> + @SuppressWarnings("unused")
>>>>>>>> private static Document getXmlDocument() throws
>>>>>>>> GenericConfigException {
>>>>>>>> try {
>>>>>>>> return ResourceLoader.getXmlDocument(JNDIConfigUtil.
>>>>>>>> JNDI_CONFIG_XML_FILENAME);
>
