[ 
https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006079#comment-13006079
 ] 

Jacques Le Roux commented on OFBIZ-4208:
----------------------------------------

Hi Carsten,

This needs a bit more work. See 
https://cwiki.apache.org/confluence/display/OFBIZ/How+to+localize+Product+and+Categories+descriptions
 and you should explain that in 
https://cwiki.apache.org/confluence/display/OFBIZ/Guide+to+OFBiz-i18n%2C++Internationalisation+of+OFBiz#GuidetoOFBiz-i18n,InternationalisationofOFBiz-ProductContentspecialremarks

I mean that by default Product.productName and ProductCategory.description 
contain the info. It's only when you need to i18n then you use 
contentWrapper.get("PRODUCT_NAME"). THis could be discussed but it's how it has 
been build from the beginning. I think i18n did not exist at the beginning and 
the Content mechanism has been added later. Both are still handled, direct 
access being the default and you need to handle it.

Thanks

> Product page meta-tag does not contain i18n content
> ---------------------------------------------------
>
>                 Key: OFBIZ-4208
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4208
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 
> 10.04, SVN trunk
>         Environment: any
>            Reporter: Carsten Schinzer
>            Priority: Minor
>              Labels: i18n, meta-tags
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n 
> content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n 
> content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n 
> content-SVNTRUNK.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> the groovy script that produces the content meta information is only 
> partially using i18n information from the Content Wrapper. Namely, it does 
> NOT use the Product or Category ContentWrapper to receive internationalized 
> content for Product Name and Description or Category Description but rather 
> the direct properties of the product entity.
> Using the ContentWrapper will overcome this shortcoming.
> The fix needs to be applied in 
> applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy
> It is assumed that ContentWrappers will handle primitive over related Content 
> properly, ie. if there is no related Content entity but only primitive 
> content, it will return that. And if there is i18n content missing in the 
> desired (current session) locale, it will return the default locale 
> translation.
> The attached fixes are for the most-used releases and trunk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to