Ideally, the multi-column layout would be handled by the applications
needing it - not by the decorator. But it has been that way for too long
to change it now.
A framework-only deployment can have applications too - the Example and
Web Tools components are examples.
Would you be willing to move the logic to the GlobalDecorator, or should
I do that myself?
-Adrian
On 3/13/2011 12:05 PM, Bruno Busco wrote:
Hi Adrian,
when I did this change I supposed that left-column where only something
related to applications.
The global decorator only had visibility of a pre-body and a body section.
The main purpose of the change was to get rid of the several variables and
use the decorator feature.
But I agree with you, at least I cannot remember of a particular reason for
not having the logic in the GlobalDecorator.
-Bruno
2011/3/13 Adrian Crum<adrian.c...@sandglass-software.com>
From the Rev 894330 commit log:
[OFBIZ-3274] - Using decorator sections to control the left-bar
The leftbar content is now defined using the "left-column"
ApplicationDecorator section instead of setting the variables
"leftbarScreenName", "leftbarScreenLocation" and "MainColumnStyle". The
logic that checks if the "left-column" section has content, and thus if a
left column must be rendered, has been moved from the GlobalDecorator to the
ApplicationDecorator.
Why was the logic moved to the ApplicationDecorator? Because of that
change, applications developed in a framework-only deployment do not render
correctly because the necessary containers are missing. From my perspective,
that change was not necessary - the logic should have stayed in the
GlobalDecorator.
-Adrian
