ContainerLoader.java is not thread-safe and it also contains some questionable code. I would like to clean it up a little, but the changes in rev 652176 are puzzling and it isn't clear what was intended.

In the current code, the static loadContainers method checks to see if a ContainerLoader instance was already loaded. If not, it creates an instance and returns an rmi-dispatcher container if one was loaded. If a ContainerLoader instance was not loaded already, the method returns null. It seems to me, if an instance of ContainerLoader was already loaded you would want to return the rmi-dispatcher instance, and not null.

Any help or insight would be appreciated.

-Adrian

Reply via email to