Hello Jacques, I have reopened https://issues.apache.org/jira/browse/OFBIZ-4225 and attach improved patch, now parm indexing start with 0 instead of 1. I have tested it for editRequest functionality and its working fine.
Thanks & Regards -- Deepak Dixit HotWax Media Pvt. Ltd. www.hotwaxmedia.com Contact :- +91-98267-54548 Skype :- deepakdixit On Mar 25, 2011, at 1:49 PM, Jacques Le Roux wrote: > Hi Deepak, > > From your comments, I'm not sure if I should wait you or do it myself (not a > big deal)? > > Jacques > > Deepak Dixit wrote: >> Thanks Jaques, >> >> Both ways are fine, We can use either 0 or 1 index. >> I have an idea to improve target-parameter functionality and I am working >> on it, will open a ticket shortly for the same. >> >> >> Thanks & Regards >> >>> Thinking more about it, I have changed my mine. I will rather revert and >>> use 0 as origin because some custom applications are >>> certainly using it... Waiting Deepkak answer on a (it seems) mixed issue at >>> https://issues.apache.org/jira/browse/OFBIZ-4225 >>> before going on >>> >>> Jacques >>> >>>> Author: jleroux >>>> Date: Thu Mar 24 06:36:58 2011 >>>> New Revision: 1084855 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1084855&view=rev >>>> Log: >>>> A patch from Leon "Minor related patch after OFBIZ-4225 issue (Lookup >>>> target-parameter in form widget is not working) fixed" >>>> https://issues.apache.org/jira/browse/OFBIZ-4228 - OFBIZ-4228 >>>> >>>> n https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a >>>> bug in fieldlookup.js which caused "Lookup >>>> target-parameter in form widget is not working"。 >>>> >>>> Now the form widget framework behaves same as widget-form.xsd specifies: >>>> using parameters.parmI (where I is the position number >>>> in the "target-parameter" list) in the related lookup screen. The position >>>> number in the list begins from 1. That implictes >>>> "parm0" is invalid. >>>> >>>> So I searched the whole project to look up whether there's "parm0" left >>>> out. That's what this patch for. >>>> >>>> Modified: >>>> ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml >>>> >>>> Modified: ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml >>>> URL: >>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml?rev=1084855&r1=1084854&r2=1084855&view=diff >>>> ============================================================================== >>>> --- >>>> ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml >>>> (original) +++ >>>> ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml Thu Mar >>>> 24 06:36:58 2011 @@ -137,7 +137,7 @@ under the License. >>>> <actions> >>>> <property-map resource="OrderUiLabels" map-name="uiLabelMap" >>>> global="true"/> >>>> <set field="title" >>>> value="${uiLabelMap.PageTitleLookupCustomerRequestItem}"/> >>>> - <set field="custRequestId" >>>> from-field="parameters.custRequestId" default-value="${parameters.parm0}"/> >>>> + <set field="custRequestId" >>>> from-field="parameters.custRequestId" default-value="${parameters.parm1}"/> >>>> <set field="queryString" from-field="result.queryString"/> >>>> <set field="viewIndex" from-field="parameters.VIEW_INDEX" >>>> type="Integer"/> >>>> <set field="viewSize" from-field="parameters.VIEW_SIZE" >>>> type="Integer" default-value="20"/> >>>> @@ -190,7 +190,7 @@ under the License. >>>> <actions> >>>> <property-map resource="OrderUiLabels" map-name="uiLabelMap" >>>> global="true"/> >>>> <set field="title" >>>> value="${uiLabelMap.PageTitleLookupQuoteItem}"/> >>>> - <set field="quoteId" from-field="parameters.quoteId" >>>> default-value="${parameters.parm0}"/> >>>> + <set field="quoteId" from-field="parameters.quoteId" >>>> default-value="${parameters.parm1}"/> >>>> <set field="queryString" from-field="result.queryString"/> >>>> <set field="viewIndex" from-field="parameters.VIEW_INDEX" >>>> type="Integer"/> >>>> <set field="viewSize" from-field="parameters.VIEW_SIZE" >>>> type="Integer" default-value="20"/> > >
