I thought the original idea that Nicolas proposed, was for this to be configurable by theme (adding a layoutSettings.VT_ICONS_LOC to data config). I think that you should be able to turn icons on and off as well as change the icon library location.
Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Apr 24, 2011, at 6:29 AM, Adrian Crum wrote: > The main problem I have with this is the idea that theme design has been > taken away from the theme designer. In other words, icons should be added by > the theme designer - they should not appear in all themes by default. > > -Adrian > > On 4/24/2011 5:26 AM, Jacques Le Roux wrote: >> It's actually related to https://issues.apache.org/jira/browse/OFBIZ-4259 >> and r1095984 >> >> I did not see any issues in Flat Grey, could you post a screenshot? >> >> If it's really blocking (I doubt we can't fix any related issues), it should >> be easy to configure with a property in widget.properties to bypass image >> rendering in menus (HtmlMenuRenderer.java around line 500) and buttons >> (MacroFormRenderer.java look for submitField.getImageLocation(context) or >> maybe rather ModelFormField.java but this one existed before, see >> http://svn.apache.org/viewvc?view=revision&revision=1095984 for files >> changed) >> >> Jacques >> >> From: "Adrian Crum" <adrian.c...@sandglass-software.com> >>> I see that icons were added to menu items - maybe in rev 1088549. Is there >>> a chance we can revert that? Or at least make it configurable on a >>> per-theme basis? The new icons break the layout in the Flat Gray theme. It >>> would be helpful if a theme can choose to use the icons or not use them. >>> >>> -Adrian >>> >>> >> >>
