ResourceBundleMapWrapper memory usage improvement
-------------------------------------------------

                 Key: OFBIZ-4268
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4268
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Philippe Mouawad


Hello,
We are working on performance improvements while load testing the application, 
and I noticed that ResourceBundleMapWrapper uses arounbd 140 Ko per Serving 
thread, in our configuration with around 1000 thread, this is a big memory 
impact.
I started investigating the class and code seems strange to me, in fact I don't 
understand why InternalRbmWrapper constructor copies creates a Map by copying 
content of ResourceBundle.
Why not only have a reference and delegate calls to the ResourceBundle ?
Furthermore since put methods throw RuntimeException, I really don't see any 
case where the Map will change.
I made a test removing this code and delegating to resourceBundle and it seems 
OK.

If someone knows why it was made like that I would really be interested, if 
there is no reason I will submit a patch

Thank you
Regards
Philippe
http://www.ubik-ingenierie.com

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to