[ 
https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-4333:
---------------------------------

    Attachment: OFBIZ-4322.patch

I propose to advance step by step.

The first patch contains model data refactoring :
 * associate ProductStoreEmailSetting to EmailTemplateSetting
 * Create view ProductStoreEmailAndSetting
 * Extend EmailTemplateSetting on content component to add contentId (don't 
create dependency between framework and content)

I change also ProductStoreEmailSetting call by ProductStoreEmailAndSetting to 
view impact on code.

I wait your comment to continue. When the data model conversion will be 
validate, I will complete the patch with refactoring service.

> Refactoring send email engine
> -----------------------------
>
>                 Key: OFBIZ-4333
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4333
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS, content, framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>              Labels: content, mail, notification
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4322.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> In OFBiz history, the first entity used was ProductStoreEmailSetting, for 
> automatic email during ecommerce process and in last time the 
> EmailTemplateSetting for specific notification.
> Both entities have the same field : bodyScreenLocation, 
> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, 
> contentType. Just primary key are differents.
> To simplify the notification system, I will suggest :
> * use only EmailTemplateSetting to edit email configuration
> * associate ProductStoreEmailSetting to EmailTemplateSetting
> * convert all service and screen that use ProductStoreEmailSetting
> * create convert service.
> * add contentId on EmailTemplateSetting (or templaceContentId) to use a 
> content for rendering email 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to