[ https://issues.apache.org/jira/browse/OFBIZ-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115284#comment-13115284 ]
Dimitri Unruh commented on OFBIZ-4341: -------------------------------------- I had a look in the SVN history. The {{Delegator.getFromPrimaryKeyCache()}} method has been changed in rev. 589514. In my opinion, we should change the method. Any other ideas? Anyway, at least we got a problem here. So, if we don't change the {{Delegator.getFromPrimaryKeyCache()}} method, we should use Martins patch :) > GenericDelegator.findOne cache not working for not-found values (cached > not-found treated like cache miss) > ---------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4341 > URL: https://issues.apache.org/jira/browse/OFBIZ-4341 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Martin Kreidenweis > Assignee: Jacques Le Roux > Attachments: OFBIZ-4341-findOne-cache-fix.patch, OFBIZ-4341.patch > > > {{GenericDelegator.findOne}} doesn't handle the cache consistently. > When it doesn't find anything, it puts {{GenericValue.NULL_VALUE}} in the > cache. When trying to read from the cache it uses the > {{getFromPrimaryKeyCache}} method, which returns null when > {{GenericValue.NULL_VALUE}} was stored in the cache, just like for cache > misses. So a not-found value in the cache is treated like a cache miss and > the cache isn't actually used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira