[
https://issues.apache.org/jira/browse/OFBIZ-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146255#comment-13146255
]
Adrian Crum commented on OFBIZ-4545:
------------------------------------
The patch is looking better, but you are still checking one of the arguments
for null, but this time you are returning null instead of an empty String. You
need to remove the argument checks. Allow the method to throw NPE instead of
returning arbitrary default values.
> DateFormat API extension
> ------------------------
>
> Key: OFBIZ-4545
> URL: https://issues.apache.org/jira/browse/OFBIZ-4545
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Dimitri Unruh
> Priority: Minor
> Attachments: OFBIZ-4545.patch, OFBIZ-4545.patch, OFBIZ-4545.patch
>
>
> Some API extensions for Dateformating
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
