On 19/12/2011, at 7:14 AM, Hans Bakker wrote: > Hi Jacopo, > > thanks for helping me, it is good try to work together instead of personally > accusing people. With the amount of commits we produce here at Antwebsystems, > it can once in a while go wrong and have errors. I am setting up a Jenkins > automated test system in our company to improve on the situation. > > I join other committers that we also worry about the amount of changes that > go into the system which could introduce errors. On the other hand without > them, it will quickly kill the OFBiz system.
Personally I believe it is poor design and code quality that will ultimately kill OFBiz. IMO the codebase could see nothing but bug fixes and still be a useful platform 5-10 years into the future unless something equally as flexible and robust comes along. It is the volume of core existing business processes and the speed at which new ones can be implemented into custom deployments that keeps it alive. The more difficult those implementations become because of poor OOTB design is what will see OFBiz usership decline. > Perhaps in the future we should insist on having junit tests for new > functions and enhancements to existing functions. > > Thanks again for your help, > > Regards, > Hans > > On 12/19/2011 03:38 PM, Jacopo Cappellato wrote: >> Yep, >> >> the problem was the line: >> >>>> -<ProductFeatureCategory productFeatureCategoryId="IMAGE" >>>> description="Image"/> >>>> +<ProductFeatureCategory productFeatureCategoryI="IMAGE" >>>> description="Image"/> >> I have fixed it. >> Even without reviewing this big commit, this kind of errors (that imply that >> very few tests were done) makes me feel nervous about the quality of the >> code committed. >> >> Jacopo >> >> >> On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote: >> >>> This commit is throwing a lot of exceptions during data loading. See the >>> buildbot report. >>> >>> -Adrian >>> >>> On 12/19/2011 6:40 AM, hans...@apache.org wrote: >>>> Author: hansbak >>>> Date: Mon Dec 19 06:40:18 2011 >>>> New Revision: 1220622 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1220622&view=rev >>>> Log: >>>> new producttype: configurable product service, using inventory
