[ 
https://issues.apache.org/jira/browse/OFBIZ-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207923#comment-13207923
 ] 

Jacques Le Roux commented on OFBIZ-4693:
----------------------------------------

Sorry I did not read your comment <<Also removed trailing whitespaces, I hope 
this is ok.>>. Forget my <<But then you should better tell us.>> ;)

So to answer that: yes it was globally OK, but is not a recommended way of 
doing (because of many false changes to track). As I said, when patching with 
Subclipse it's not a pb for me, as it hides all of them  (maybe I have a 
setting to ignore white spaces changes there).

                
> return value of currentDelegatorTenantId.trim() ignored in 
> org.ofbiz.webapp.control.LoginWorker.login(HttpServletRequest, 
> HttpServletResponse)
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Brohl
>            Assignee: Jacques Le Roux
>              Labels: patch
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: LoginWorker.java.patch
>
>
> The return value of currentDelegatorTenantId.trim() is ignored in 
> org.ofbiz.webapp.control.LoginWorker.login(HttpServletRequest, 
> HttpServletResponse) so trim() has no effect.
> I will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to