[ 
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240302#comment-13240302
 ] 

Jacopo Cappellato commented on OFBIZ-4765:
------------------------------------------

Markus, the patch seems to contain a diff between two local versions; there are 
also unrelated changes.

                
> build.xml in hot-deploy folder is not called correctly in the main build.xml
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4765
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4765
>             Project: OFBiz
>          Issue Type: Wish
>    Affects Versions: SVN trunk
>            Reporter: Markus M. May
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4765-fix-buildxml.patch, 
> OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is 
> executed for each subdirectory (framework, application, specialpurpose) with 
> the fileset: 
> <filelist dir="." files="specialpurpose/build.xml"/>
> Only for the hot-deploy folder the fileset is quite different:
> <fileset dir="${basedir}/hot-deploy" casesensitive="no">
>    <exclude name="disabled/**"/>
>    <include name="*/build.xml"/>
> </fileset>
> This is calling the build.xml directly in the hot-deploy components, which is 
> an error, if you do have several dependent components in there, which needs 
> to get build in the right order. I propose to use the following filelist:
> <filelist dir="." files="hot-deploy/build.xml"/>
> Problem could be, that not every project do have an build.xml file in this 
> folder (or is this already a requirement?). If it is not then we would need 
> to check, if this build.xml is there, then execute this, and otherwise use 
> the already existing one.
> A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to