Hi Adrian, Please see inline comments
Op 12 april 2012 14:21 schreef Adrian Crum (Commented) (JIRA) < j...@apache.org> het volgende: > > [ > https://issues.apache.org/jira/browse/OFBIZ-4783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252375#comment-13252375] > > Adrian Crum commented on OFBIZ-4783: > ------------------------------------ > > It might help to learn the differences between the ant version bundled > with your OS and the ant version bundled with OFBiz. In particular, see > what changed in the <available> element between those versions. > Possible incompatibilities between my OS native ant version and the version bundled with OFBiz is the reas0n why I have my CI environment (Jenkins) to build the OFBiz project with the (OFBiz) bundled version. As I do locally. And I can't imagine that triggering ./ant <target> in the root directory of OFBiz would use the OS native ant, as otherwise many more would have issues. > > Pierre - Framework code MUST have good unit tests and those tests MUST > have good code coverage. Before Adam made these test improvements, OFBiz > was very buggy and the bugs were difficult to track down. > I agree, It must be good for the framework and at least adequate for the applications (incl specialpurpose). I can't judge on the unit tests provided. However, I did see that unit tests for various special purpose apps unit tests are missing. I guess it is like having help screens. Always the last items on the list to be resolved. I am not passing judgements here, as I am as good or as bad as the next guy. ;-) > > Cobertura has an incompatible license, so we can not include it in OFBiz. > > I guess that why we have the target 'download-cobertura' since Dec 19, 2010 and provided by Erwan as an OFBiz enhancement. My point is that the cobertura java code isn't intended for production purposes, but only for testing and analysis. And as such it shouldn't be part of the framework by default. But that is another issue regarding improving OFBiz. The issue exists, because currently the implemented solution doesn't work (and I can't oversee since when). And I am not the only one who experienced it. I am just contributing to improve OFBiz. I am not doing this to satisfy my ego. If the PMC believes that my contributions are not adding any value and are disruptive to the harmony and the status-quo of the project I welcome their feedback. > > ./ant can't find the cobertura class > > ------------------------------------ > > > > Key: OFBIZ-4783 > > URL: https://issues.apache.org/jira/browse/OFBIZ-4783 > > Project: OFBiz > > Issue Type: Bug > > Components: framework > > Affects Versions: SVN trunk > > Reporter: Erwan de FERRIERES > > Labels: qa > > Fix For: SVN trunk > > > > > > ./ant can't find the cobertura class, and deactivate the code coverage > function. > > in framework/base/build.xml: > > {code} > > <condition property="exclude.cobertura" > value="org/ofbiz/base/config/Cobertura*.java"> > > <not> > > <available > classname="net.sourceforge.cobertura.instrument.ClassInstrumenter" > classpathref="local.class.path"/> > > </not> > > </condition> > > {code} > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > > Regards, Pierre