[
https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254649#comment-13254649
]
Jacques Le Roux commented on OFBIZ-4810:
----------------------------------------
Hi Michael,
You commented out
{code}
<entity-one entity-name="ContactMechType"
value-field="contactMechType">
<field-map field-name="contactMechTypeId"
from-field="partyAndContactMech.contactMechTypeId"/>
</entity-one>
{code}
But you left
{code}
<if-compare operator="equals" value="N" field="contactMechType.hasTable"/>
{code}
This is inconsistent. Did you intend to also remove the check upon
contactMechType.hasTable (and forgot)? And then why to remove this check?
BTW I'd use rather if-compare-field, but that's very minor.
> createPartyContactMech: check for infoString is done without using the
> contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
