[ 
https://issues.apache.org/jira/browse/OFBIZ-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4830.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Tom,

Your slightly amended patch is in trunk at revision: 1328205.

It was a real good idea to provide a selenium test suite: you forgot authview/ 
for the bottom buttons in editperson.ftl and changepassword.ftl

                
> eCommerce Customer Code Cleanup
> -------------------------------
>
>                 Key: OFBIZ-4830
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4830
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: demo-trunk
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4830 eCommerce Customer Code Cleanup.html, 
> OFBIZ-4830 eCommerce Customer Code Cleanup.patch
>
>
> 1. In OFBIZ-4822 it was decided that request to authview would be removed 
> from the eCommerce customer ftl files because their only purpose was to set 
> URL to https. The set field "donePage" in CustomerScreens.xml editperson 
> effects the same result.
> 2. There are brackets in the password.ftl display for the href:
>  <a href="<@ofbizUrl>authview/${donePage}</@ofbizUrl>" 
> class="button">[${uiLabelMap.CommonGoBack}]</a>
> The brackets are inconsistent with the display for similar elements in the 
> applications

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to