[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258274#comment-13258274
]
Wai edited comment on OFBIZ-4813 at 4/20/12 2:33 PM:
-----------------------------------------------------
Jacques,
Point#1:
Regarding Tomahawk spinner image. You need to modify
themes/tomahawk/webapp/tomahawk/css/style.css with the following changes
specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif
inside the themes subdirectory would be used. That's why the
#wait-spinner-image style specifies /images/spinner.gif as the target image to
use and not /tomahawk/images/spinner.gif. To be consistent, all themes use
/images/spinner.gif as the spinner image.
{code}
#wait-spinner-image {
height:45px;
width:45px;
background-repeat: no-repeat;
background-image:url(/images/spinner.gif);
}
{code}
Note: The previous patch "ofbiz-4813patch" already contained the changes to
the css files. I do not know why it was not committed with the rest of the
code changes? "ofbiz-4813-additional.patch" was provided to address that.
Point#2:
Regarding i18n issue for the popup alert. The alert has no problem showing the
french message. The problem is on the server side. It is sending english
regardless of what the user's currently selected locale is. I can create a
jira report on that and find some time to fix it. In my opinion, an alert is
more appropriate as it is a session wide phenomena that needs to be handled
immediately. Hence a modal alert, front and center, seem more appropriate.
Nevertheless, whatever you decide is good.
Point#3:
Regarding the double spinner image, you can see it in
https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000
and click on the appropriate button to see the double spinner image.
Again, "ofbiz-4813patch" already contained this change but was not committed.
"ofbiz-4813-additional.patch" was provided to address that.
Thanks,
Wai
was (Author: wt):
Jacques,
Point#1:
Regarding Tomahawk spinner image. You need to modify
themes/tomahawk/webapp/tomahawk/css/style.css with the following changes
specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif
inside the themes subdirectory would be used. That's why the
#wait-spinner-image style specifies /images/spinner.gif as the target image to
use and not /tomahawk/images/spinner.gif. To be consistent, all themes use
/images/spinner.gif as the spinner image.
#wait-spinner-image {
height:45px;
width:45px;
background-repeat: no-repeat;
background-image:url(/images/spinner.gif);
}
Note: The previous patch "ofbiz-4813patch" already contained the changes to
the css files. I do not know why it was not committed with the rest of the
code changes? "ofbiz-4813-additional.patch" was provided to address that.
Point#2:
Regarding i18n issue for the popup alert. The alert has no problem showing the
french message. The problem is on the server side. It is sending english
regardless of what the user's currently selected locale is. I can create a
jira report on that and find some time to fix it. In my opinion, an alert is
more appropriate as it is a session wide phenomena that needs to be handled
immediately. Hence a modal alert, front and center, seem more appropriate.
Nevertheless, whatever you decide is good.
Point#3:
Regarding the double spinner image, you can see it in
https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000
and click on the appropriate button to see the double spinner image.
Again, "ofbiz-4813patch" already contained this change but was not committed.
"ofbiz-4813-additional.patch" was provided to address that.
Thanks,
Wai
> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
> Key: OFBIZ-4813
> URL: https://issues.apache.org/jira/browse/OFBIZ-4813
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Wai
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
> ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session
> timeout. This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large
> frame containing a message indicating session has timeout. Should show a
> more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box
> results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window
> to popup.
> 3. A large round spinner is shown when the ajax dialog is loading. This
> spinner image comes from http://mentalized.net/activity-indicators/ and is
> royalty free. Note the round spinner does not show in Tomahawk theme as it
> uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
