I hadn't thought of that. Thanks for the tip!
-Adrian
On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:
there are actually use cases (and good motivations) for both options and this
is why I proposed the most granular one. If you are building new *java* code
then you could run:
ant build run-tests
Jacopo
On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:
The same argument could run in the opposite direction as well though, if I just
changed a script/simple-method why should I have to build again? Although to
be honest I don't really mind either way, running a build when nothing has
changed takes virtually no time at all.
Regards
Scott
On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
-1
If you are running tests, then most likely you are developing new code. So, if
the tests fail, I should be able to make corrections to my source code and then
run the tests again without having to insert a build step.
-Adrian
On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
What do you think? In order to run most of the tests successfully you need to run
load-data that already depends on "build"...
Here is the code change I would like to commit:
Index: build.xml
===================================================================
--- build.xml (revision 1328357)
+++ build.xml (working copy)
@@ -868,7 +868,7 @@
<antcall target="load-admin-user-login"/>
</target>
-<target name="run-tests" depends="build"
+<target name="run-tests"
description="Run OFBiz default tests; you have to manually execute 'ant
load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
<java jar="ofbiz.jar" fork="true" resultproperty="test.result">
<jvmarg value="${memory.initial.param}"/>
@@ -910,7 +910,7 @@
<env key="LC_ALL" value="C"/>
</java>
</target>
-<target name="run-test" depends="build"
+<target name="run-test"
description="Run a single test, syntax eg: ant run-test
-Dtest.component=service -Dtest.case=service-soap-tests">
<fail unless="test.component">test.component is a required parameter:
-Dtest.component=componentname</fail>
<fail unless="test.case">test.case is a required parameter:
-Dtest.case=testcasename</fail>
@@ -936,7 +936,7 @@
</condition>
</fail>
</target>
-<target name="run-test-suite" depends="build"
+<target name="run-test-suite"
description="Run a single test suite, syntax eg: ant run-test-suite
-Dtest.component=mycomponent -Dtest.suiteName=mytests">
<fail unless="test.component">test.component is a required parameter:
-Dtest.component=componentname</fail>
<fail unless="test.suiteName">test.suiteName is a required parameter:
-Dtest.suiteName=testsuitename</fail>
Jacopo