[ 
https://issues.apache.org/jira/browse/OFBIZ-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264593#comment-13264593
 ] 

Tom Burns commented on OFBIZ-4838:
----------------------------------

The suggested resolution assumes these requirements:
1. Party status changed is limited to Enabled and Disabled (see StatusItem 
statusTypeId value="PARTY_STATUS")
2. Legacy party data with null status_id's must be supported.

Three patches follow:

1. Party Entity Set Status Enabled 
a) Allows the drop down in Edit Group Information to display null values. 
If nulls are not displayed then the application is displaying incorrect data. 
Displaying nulls allows a user to change the status to Enabled.
b) In PartyServices.java > setPartyStatus nulls are set to Enabled AND STORED.
Note this will be triggered on any change to the party, not just changes to 
status.

2. Party Group Status Change sets all party entries in the demo data to 
Enabled. This makes the demo data consistent with the StatusItem limitation for 
party. 
Note in PartyManager "Create Party Group" sets status to Enabled by default.

Other concerns resulting from the analysis of, but not addressed in, this issue 
may be bugs or required improvements. Notes to be attached.

3. A throwaway test for the setPartyStatus service. 
                
> Party Manager Party StatusId Update Fails
> -----------------------------------------
>
>                 Key: OFBIZ-4838
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4838
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
>         Environment: demo-trunk
>            Reporter: Tom Burns
>            Priority: Minor
>
> Party Manager does not update the party status id correctly.
> To reproduce:
> First:
> In Party Manager lookup party id "Company"
> Click "Update" In Profile > Party Group Information
> Note: Status Id drop-down field displays Enabled
> Click "Save"
> Then:
> In Web Tools Interactive version lookup Party party_id = "Company"
> Expect: StatusId = "Enabled"
> Actual: StatusId = NULL
> PartyServices setPartyStatus is not updating the party status.
> The question before fixing, is there any reason to allow null status id's on 
> a party?
> Shouldn't every party either be Enabled or Disabled? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to