[
https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268342#comment-13268342
]
Scott Gray commented on OFBIZ-904:
----------------------------------
No it shouldn't, it is quite possible for a ProductStore to be supplied from
multiple facilities as specified by the ProductStoreFacility entity.
The code appears to run that block in order to determine the daysToShip if
inventory is available. In this case I think it would probably be better to
call isStoreInventoryAvailable and if inventory is available then either get
the daysToShip from the facility (if we have a facilityId) or get the lowest
value from the facilities associated via ProductStoreFacility.
> Error when "Inventory Facility Id" is left blank in product store settings
> --------------------------------------------------------------------------
>
> Key: OFBIZ-904
> URL: https://issues.apache.org/jira/browse/OFBIZ-904
> Project: OFBiz
> Issue Type: Bug
> Components: product, specialpurpose/ecommerce
> Environment: OFBiz Rev. 529997 on Windows XP.
> Reporter: Michel Dielissen
>
> When creating a new store and the "Inventory Facility Id" field is left blank
> (with the store settings) then the productlist (Browse categories in the
> e-commerce store) gives an error and is not rendered.
> Error:
> 2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [
> ModelScreen.java:148:ERROR] Error rendering screen
> [component://ecommerce/widget/CatalogScreens.xml#productsummary]:
> org.ofbiz.base.util.GeneralException: Error running BSH script at location
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]:
> org.ofbiz.base.util.GeneralException: Error running BSH script at
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
> line [65]: Sourced file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> : if ( product != null ) {
> (Sourced file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> internal Error: Null value in getAssignableForm.) (Error running BSH script
> at
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
> line [65]: Sourced file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> : if ( product != null ) {
> (Sourced file:
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
> internal Error: Null value in getAssignableForm.)). Rolling back transaction.
> Think it has something todo with:
> file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
> 2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [
> ServiceDispatcher.java:459:DEBUG] Sync service
> [ecommerce/getInventoryAvailableByFacility]
> So maybe the "Inventory Facility Id" field has to be a required field? Or
> maybe better to run the "getInventoryAvailableByFacility" only when an
> Inventory Facility is filled with the store settings?
> Comment Jacopo: this should be improved; for example the facility in the
> store should be mandatory if the requireInventory flag is set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
