[ 
https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272143#comment-13272143
 ] 

Jacques Le Roux commented on OFBIZ-4866:
----------------------------------------

Thanks Ankit,

It was late and stupidely I only added one item, so the button did not show ;)

About my other point, I think we should really avoid do "duplicate" ecommerce 
code in order manager. Could we not rather refactor the code and include only 
one version in order manager then used also from ecommerce? Because dependency 
from order manager is correct but other way is bad. I know you did not "reuse" 
the code but duplicated it rather.

To summarize:
* Duplicate/adapt ecommerce in order manager => bad
* Make a dependency from order manager to ecommerce => bad
* Make a dependency from ecommerce to order manager => best practise

I might have missed something (just browsed the patch), then please explain.


                
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
>                 Key: OFBIZ-4866
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4866
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to