yeah, it could be something unrelated to Adrian's commit. Adrian let me know if you find something or if you want me to have a look as well.
Jacopo On May 12, 2012, at 9:20 AM, Adam Heath wrote: > Hold off. On trunk, I get issues, but if I reverse the below patch, it > doesn't solve the problem. git bisect can be confused when 2 problems are > happening. I'll check this further in the morning. > > On 05/12/2012 02:08 AM, Adrian Crum wrote: >> The tests cases pass on my local machine. Could you provide the test >> report XML file please? >> >> -Adrian >> >> On 5/12/2012 3:59 AM, Adam Heath wrote: >>> On 05/11/2012 05:25 AM, adri...@apache.org wrote: >>>> Author: adrianc >>>> Date: Fri May 11 10:25:33 2012 >>>> New Revision: 1337103 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1337103&view=rev >>>> Log: >>>> Fixed broken Mini-language<check-errors> element (second try). >>>> >>>> Modified: >>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java >>>> >>>> >>>> Modified: >>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java >>>> >>>> URL: >>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java?rev=1337103&r1=1337102&r2=1337103&view=diff >>>> >>>> ============================================================================== >>>> >>>> --- >>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java >>>> (original) >>>> +++ >>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java >>>> Fri May 11 10:25:33 2012 >>>> @@ -52,8 +52,10 @@ public final class CheckErrors extends M >>>> List<Object> messages = >>>> methodContext.getEnv(this.errorListNameFse.expandString(methodContext.getEnvMap())); >>>> >>>> if (messages != null&& messages.size()> 0) { >>>> if (methodContext.getMethodType() == MethodContext.EVENT) { >>>> + methodContext.putEnv(simpleMethod.getEventErrorMessageListName(), >>>> messages); >>>> methodContext.putEnv(this.simpleMethod.getEventResponseCodeName(), >>>> getErrorCode(methodContext)); >>>> } else { >>>> + methodContext.putEnv(simpleMethod.getServiceErrorMessageListName(), >>>> messages); >>>> methodContext.putEnv(this.simpleMethod.getServiceResponseMessageName(), >>>> getErrorCode(methodContext)); >>>> } >>>> return false; >>> >>> Try again, this breaks the test cases in *many* places. >>> >>> 21:53:03 -0500 >>> doogie@adam-ofbiz-testing[1]:/home/doogie/code/ofbiz/new(74b6f9d6f6140cd64e6a4754b1f527601af6e95b|BISECTING)$ >>> git bisect good >>> bb93be67832c3120e5b4cf063832244cd8f9fe86 is the first bad commit >>> commit bb93be67832c3120e5b4cf063832244cd8f9fe86 >>> Author: adrianc <adrianc@13f79535-47bb-0310-9956-ffa450edef68> >>> Date: Fri May 11 10:25:33 2012 +0000 >>> >>> Fixed broken Mini-language <check-errors> element (second try). >>> >>> >>> git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1337103 >>> 13f79535-47bb-0310-9956-ffa450edef68 >>> >>> :040000 040000 128f25ae17b7205cf1f47c2835a2c17056d0ebe1 >>> eb0e33d1d4fbcc322ac4f2bab1f2990bdf01ee18 M framework >>> 21:55:01 -0500 >>> doogie@adam-ofbiz-testing[1]:/home/doogie/code/ofbiz/new(74b6f9d6f6140cd64e6a4754b1f527601af6e95b|BISECTING)$ >>> git bisect log >>> git bisect start >>> # good: [276d224f582251360dd572fe072b9938d8412d2b] More work on >>> Mini-language: API fixes, overhauled <if-regexp>, >>> <if-validate-method>, and <check-id> elements. >>> git bisect good 276d224f582251360dd572fe072b9938d8412d2b >>> # bad: [521c68a9b06e0cde719439ae70c9a051a0003991] FORMATTING: Add some >>> missing final newlines to tons of files. >>> git bisect bad 521c68a9b06e0cde719439ae70c9a051a0003991 >>> # good: [3ec683d716257e8c56394a79c44e589d3c61ffb6] FEATURE: Add >>> gen-kek ant target. >>> git bisect good 3ec683d716257e8c56394a79c44e589d3c61ffb6 >>> # good: [f42a817cce883e167835c2408997f3b5b21fd431] Changed the Anon >>> Contact Us in ecommerce to use the improved captcha event. Also >>> removed some bad code that would allow a user to impersonate another >>> user and discover their name simply by entering that person's email >>> address in the form. >>> git bisect good f42a817cce883e167835c2408997f3b5b21fd431 >>> # bad: [d6db6a7f6b22f05cd6864dacec2977771f7d2fd2] Fixed Mini-language >>> validation for the <check-id> element. >>> git bisect bad d6db6a7f6b22f05cd6864dacec2977771f7d2fd2 >>> # bad: [bb93be67832c3120e5b4cf063832244cd8f9fe86] Fixed broken >>> Mini-language <check-errors> element (second try). >>> git bisect bad bb93be67832c3120e5b4cf063832244cd8f9fe86 >>> # good: [74b6f9d6f6140cd64e6a4754b1f527601af6e95b] Fixed broken >>> Mini-language <check-errors> element. >>> git bisect good 74b6f9d6f6140cd64e6a4754b1f527601af6e95b >>> >
