A small clarification: in Jira I suggested to remove the empty folder framework/base/lib/javacc and not the javacc compile in $ofbiz_home/lib/build/javacc/
Jacopo On May 20, 2012, at 10:22 AM, Jacques Le Roux wrote: > https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13274631&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13274631 > https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249 > > Thanks for your help > > Jacques > > From: "Scott Gray" <[email protected]> >> +1, I'm really sick and tired of this Jacques. The lack of care shown in >> obvious places like this makes me very concerned about all of your commits >> in general, I really don't want to have to start closely reviewing every >> single one. Given that you are OFBiz's most prolific committer by a large >> margin, you're taking time away from the other committers by forcing us to >> review all of your work and that's just not fair. I regularly see basic >> problems with your commits but I just don't have the energy to respond most >> of the time unless it's obviously going to break something. >> >> Before committing please just stop and ask yourself a few questions: >> - Do I fully understand the problem I'm about to try and solve? >> - Have a taken all practical steps to ensure this change won't break >> anything? >> - Is this the best solution to the problem? >> >> If the answer to any of the above is no then just stop, wait, think and >> discuss. >> >> Thanks >> Scott >> >> On 20/05/2012, at 12:52 AM, Adrian Crum wrote: >> >>> Jacques, >>> >>> I am going to repeat what Scott said the other day: >>> >>> Before you commit, run ant clean-all load-demo run-tests. >>> >>> This lack of care in the commit process needs to stop. >>> >>> -Adrian >>> >>> On 5/19/2012 1:41 PM, Adrian Crum wrote: >>>> The project will not compile after this change. >>>> >>>> -Adrian >>>> >>>> On 5/19/2012 11:57 AM, [email protected] wrote: >>>>> Author: jleroux >>>>> Date: Sat May 19 10:57:40 2012 >>>>> New Revision: 1340414 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev >>>>> Log: >>>>> Following >>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249 >>>>> Moves to Attic: >>>>> framework/base/lib/ant/ant-nodeps-1.8.1.jar => can be removed IMO. It >>>>> was added with ant 1.8 by Hans, not sure why (no comment about need), >>>>> seems to contains no needed stuff >>>>> framework/base/lib/javacc can be removed IMO. The Java Compiler >>>>> Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was >>>>> added by Marco, not sure why (no comment about need) >>>>> framework/base/lib/Tidy.jar was used at bottom of eCommerce pages >>>>> before, no longer needed >>>>> framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added >>>>> with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT >>>>> task >>>>> framework/base/lib/commons/commons-vfs-20070730.jar certainly added >>>>> with Webslinger can be removed now >>>>> >>>>> Removed: >>>>> ofbiz/trunk/framework/base/lib/Tidy.jar >>>>> ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar >>>>> ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar >>>>> ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar >>>>> ofbiz/trunk/framework/base/lib/javacc/ >>>>> ofbiz/trunk/lib/ >>>>> >>
