On 05/23/2012 11:51 AM, Jacopo Cappellato wrote:
> I just realized that line 150 in DBCPConnectionFactory:
> 
> factory.setValidationQuery("select example_type_id from example_type limit 
> 1");
> 
> is a dependency on ExampleType entity declared in the "example" component.
> 
> This is probably not a big deal but now that we have moved the "example" 
> component to specialpurpose it is more important to have framework code not 
> dependent on it.
> 
> What is your preference to fix this? Some options I can think of:
> 
> 1) modify the sql to use SequenceValueItem or another entity declared in the 
> same component (or, less ideally, another framework component like "commons")

DBCPConnectionFactory is in framework/entity; having it require a
framework/entity/entitymodel seems the safest approach.

Reply via email to