OK, at revision: 1343016, I have replaced all remaining title="${uiLabelMap.CommonEmptyHeader}" by title=" ". I tested
https://localhost:8443/ordermgr/control/OrderPurchaseReportOptions for OrderByReferrer form
In ListPartyCommEvents I replaced
<set field="toComplete"
value="${bsh:"COM_ROLE_READ".equals(roleStatusId)?"PartyToComplete":"CommonEmptyHeader"}"/>
by
<set field="toComplete" value="${groovy: 'COM_ROLE_READ'.equals(roleStatusId) ?
'PartyToComplete' : ' '}"/>
I tried to test but it's a real pain to create a communication event from
https://localhost:8443/sfa/control/createCommunicationEvent. I always ended with <<Column 'WORK_EFFORT_ID' cannot accept a NULL
value.)>> (due to <<Service ECA [createCommunicationEventWorkEff]>>)
I guess it's ok anyway, chapter closed
Jacques
From: "Paul Foxworthy" <[email protected]>
Hi Jacques,
If we reduce hundreds of uses to just a few, it's probably worthwhile. If
there isn't a simple rule for what's left, I agree we can use title=" ".
Cheers
Paul Foxworthy
Jacques Le Roux wrote
What about the few other cases where it's not button for a hyperlink?
Maybe there a simple title="" is enough though, I did not try
Of course I guess you noticed
http://svn.apache.org/viewvc?view=revision&revision=1340376
http://svn.apache.org/viewvc?view=revision&revision=1340374
Anyway still easy to change in a way or another by a S/R
Jacques
From: "Paul Foxworthy" <[email protected]>
Hi Christian,
I see your point.
How about a rule that field won't display a prompt if its content is a
single hyperlink, unless a title is explicitly defined? A little
arbitrary,
but easy to implement.
Cheers
Paul Foxworthy
Christian Geisert wrote
Paul Foxworthy schrieb:
If the intention is to override the default behaviour, wouldn't it be
clearer
to add an attribute to the widget along the lines of
showTitle="false"
or perhaps
useFieldNameForTitle="false"
instead of fighting with a fake title that's not really a title at all?
The default value out of the schema for the attribute would, of course,
be
"true".
What do people think?
It's a little bit less hackish, but still a workaround ;-)
Let's go another step back.
In all the cases I had a closer look the field with CommonEmptyHeader
was an additional button (Cancel/Delete) to the default Submit button
(Create/Save etc.). I guess this is modeled after HTML.
So I think the best thing would be to add a button as another field type
to Forms.
Christian
-----
--
Coherent Software Australia Pty Ltd
http://www.cohsoft.com.au/
Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Re-svn-commit-r1338836-in-ofbiz-branches-release12-04-framework-base-dtd-framework-base-src-org-ofbi-tp4631741p4632477.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
-----
--
Coherent Software Australia Pty Ltd
http://www.cohsoft.com.au/
Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Re-svn-commit-r1338836-in-ofbiz-branches-release12-04-framework-base-dtd-framework-base-src-org-ofbi-tp4631741p4632484.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
