[ 
https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414500#comment-13414500
 ] 

Tom Burns commented on OFBIZ-4960:
----------------------------------

Good Question!

All I can say, after the fact, is that I "THINK?" 
"<not><if-empty field="example"/></not>"
was removed because I did not see a path in the code that reached the 
"CommonExampleDecorator" without sending the exampleID.
Likely a misguided attempt at efficiency.

It's called from Screens:
EditExample
EditExampleItems
EditExampleFeatureAppls

All of which pass an id.

As for the reason for removing the fail:
<fail-widgets>
    <container 
style="h1"><label>${uiLabelMap.ExampleNewExampleFeature}</label></container>
</fail-widgets>
Honestly do not remember.

I do not think omitting these changes will have an impact on the functionality 
of the feature.

I'll try to keep better notes in the future.

Tom



                
> Example Application Issues
> --------------------------
>
>                 Key: OFBIZ-4960
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4960
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: Release 10.04, SVN trunk
>         Environment: SVN Trunk
>            Reporter: Tom Burns
>            Priority: Minor
>         Attachments: OFBIZ-4960 Example.patch
>
>
> There are several defects in the Example application under the Example and 
> Feature menus.
> Problem path 1:
> Find Example > Find Example
> Select EX01
> Click Items Tab (or Features)
> Click Example Tab
> Expected: Example Details form in the context of the Example menus
> Actual: New Example Form under Example Application menus
> Problem path 2:
> Example > click New Example 
> Enter a new example
> Expected: Example Details form to add Items and Features to the New Example
> Actual: Example page filtered on newly created example
> (this is a problem for a new user who will not know how to clear the Example 
> Id from the Search Options form. A better path would be to go to the edit 
> forms where the user can add additional information on the example i.e. Items 
> and Features)
> Problem path 3:
> Features > New Example Features 
> Enter a Description > Click Create
> Click Examples 
> Expected: Examples to appear under the Examples menu.
> Actual: New Example Feature opens under the Example Application menu.
> Problem 3 Cont:
> Enter a Type and Sequence Num
> Click Add
> Expected: Create a new Example Feature Appl
> Actual: Error Problem 3: Error missing exampleFeatureId

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to