Yes, I agree we should do an overhaul there. I agree it's not pretty. It works,
as long as you don't need more than one JMS service,
not sure if you need more (seems that Adrian was asking for).
I have never used more than one yet. It could be that I will need more than one
soon. So would be a perfect match, though I have no
planning yet...
Jacques
From: "Jacopo Cappellato" <jacopo.cappell...@hotwaxmedia.com>
Speaking about DCC, I see a series of commits you did about it that make me
uncomfortable; I am talking about the ones related to:
https://issues.apache.org/jira/browse/OFBIZ-3987
https://issues.apache.org/jira/browse/OFBIZ-4296
for reference this is probably at the beginning of the story (no commit
associated to it):
https://issues.apache.org/jira/browse/OFBIZ-4202
Could you please help me to understand all these commits? Would you consider
reverting all of them and then rediscussing the
*original* issue in the dev list and come up with a good design?
After this will be done we will be able to resolve also these:
https://issues.apache.org/jira/browse/OFBIZ-4453
https://issues.apache.org/jira/browse/OFBIZ-4454
https://issues.apache.org/jira/browse/OFBIZ-4455
Jacopo
On Jun 26, 2012, at 7:04 PM, Jacques Le Roux wrote:
Sorry I did not get a chance to look at it seriously since. As long as it does
not prevent DCC to work it's fine with me
Jacques
From: "Jacopo Cappellato" <jacopo.cappell...@hotwaxmedia.com>
The patch attached to OFBIZ-4453 has issues and I don't see how it can fix the
problems introduced by the commits I reported at
the beginning of this thread. The patch I have attached to an earlier post in
this thread at least should revert all that work.
Jacopo
On Jun 24, 2012, at 12:15 PM, Jacques Le Roux wrote:
I just did a quick review of the status:
https://issues.apache.org/jira/browse/OFBIZ-4455 must obviously be done: "Prevent a
Singelton creation with double lock "
There is a pending patch from Martin Kreidenweis at
https://issues.apache.org/jira/browse/OFBIZ-4453 which needs our attention,
fortunately it sill applies (did not get further)
Not sure I will get enough time this weekend to work on this...
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
I will have a look this weekend...
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
From: "Jacopo Cappellato" <jacopo.cappell...@hotwaxmedia.com>
On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting
issue following
https://issues.apache.org/jira/browse/OFBIZ-4296
See also https://issues.apache.org/jira/browse/OFBIZ-4454
annoying... in short, the old JMS support has been broken by a series of non
appropriate fixes (that has been committed to
trunk
and backported to branches) and then it was decided that a refactoring was
necessary.
There were issues, else I will not have messed with that. Notably when using
DCC, IIRW...
Jacques
Jacopo
